Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 nav menu tweaks #6906

Merged
merged 3 commits into from
Aug 6, 2021
Merged

v3.0 nav menu tweaks #6906

merged 3 commits into from
Aug 6, 2021

Conversation

jeremystretch
Copy link
Member

  • Reduce left spacing of nav menu items
  • Swap group/link colors
  • Highlight nav links on hover
  • Increase nav link text size
  • Increase width of sidebar profile button under mobile view

@thatmattlove
Copy link
Contributor

A couple of issues I see:

When "hidden", the icons aren't aligned:

Screen Shot 2021-08-06 at 09 02 24

We need to differentiate the active color vs the hover color, for example (Circuit Types is hovered, but Circuits is active):

Screen Shot 2021-08-06 at 09 02 55

I'm not sure I like the child link color being blue, but I'm also not sure I have a better idea :)

In dark mode, I think we need to make the nav link color not white, not sure exactly what though.

Screen Shot 2021-08-06 at 09 04 41

Maybe the same CSS/SCSS variable as the light mode color, which should be more muted in dark mode, but maybe something custom.

Let me know if you want me to take a swing at these items, or if you want to.

@thatmattlove
Copy link
Contributor

One other thing: this may or may not have been intentional, but on smaller screens, the profile button is now full-width:

Screen Shot 2021-08-06 at 09 22 41

I don't necessarily see this as a bad thing, but wanted to point it out.

@jeremystretch
Copy link
Member Author

When "hidden", the icons aren't aligned:

Thanks, I didn't notice that. Can we just make the NetBox icon the same size as the others? That would look nicer overall I think.

We need to differentiate the active color vs the hover color, for example (Circuit Types is hovered, but Circuits is active):

IMO this isn't really necessary but I'm open to suggestions.

One other thing: this may or may not have been intentional, but on smaller screens, the profile button is now full-width

Yep, that was intentional. Looks more natural IMO than a partial-width button.

@jeremystretch
Copy link
Member Author

I've fixed the icon alignment. Is there anything else we need to do as part of this? Happy to keep experimenting with link & hover colors, but would like to merge this before conflicts start popping up.

@jeremystretch jeremystretch merged commit fe54ace into feature Aug 6, 2021
@jeremystretch jeremystretch deleted the nav-menu-tweaks branch August 6, 2021 21:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants