Add list view for device components #3719
Conversation
|
Are we good, as a start, with the generic columns (parent/device, name, type, description, cable)? |
|
@DanSheps I think it is fine for all models except interface. The interface model is just to core to the NetBox mission that I think it justifies overriding the table definition with more relevant fields. But if that becomes a line in the sand blocking this from moving forward, I will concede. |
netbox/dcim/tables.py
Outdated
| component_type = 'Interfaces' | ||
| parent = tables.LinkColumn(order_by=('device', 'virtual_machine')) | ||
|
|
||
| class Meta(InterfaceTable.Meta, DeviceComponentDetailTable.Meta): |
There was a problem hiding this comment.
Is there a need to inherit from other Meta classes here, since we're setting the parameters anyway? If there is, inheritance order should be consistent with the other component tables.
There was a problem hiding this comment.
I believe we are taking the model from some and the columns from another, but for this one most likely not.
I believe I set it mostly for a "in the future case" and to maintain consistency with the other models but it looks like I goofed on the ordering.
|
|
||
| class Meta(BaseTable.Meta): | ||
| order_by = ('device', 'name') | ||
| fields = ('pk', 'device', 'name', 'type', 'description', 'cable') |
There was a problem hiding this comment.
I'd recommend removing type from this table and adding it only to the tables for models where it's a field (similar to how we're handling device).
There was a problem hiding this comment.
I have adjusted Interface and DeviceBay to instead not inherit the Component meta, as those are the only ones that will have a differing field list.
What other fields do you think should be added? |
Fixes: #3564