fix #17960 by adding 6 more tunnel encap options #18097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would not recommend simply adding the OpenVPN and Wireguard to the choice field. From comment #14683 (comment) a set of fields are necessary to specify the crypto information for WireGuard tunnels. I will expect the same to be necessary for OpenVPN tunnels using Client & Server Certificates. |
|
I don't have any feelings on OpenVPN or WireGuard. I'm happy to remove them from the commit but I don't currently use or understand them so if more work is needed on the crypto side modeling, I'm not the guy unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17960
I included all 6 types suggested in the issue. I did not include an "other" because it seems like that's against house style (there are a limited number of tunnel encap types, we could get them all in netbox).
They should now show as an option as a tunnel encap. I wasn't sure what the proper style was for the order of the choices so I sorted them by what I thought was most common. Happy to change the PR to some other sort.