Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17986: Correct label for disk size when bulk editing virtual machines #17992

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fixes #17986: Correct label for disk size when bulk editing virtual machines #17992

merged 2 commits into from
Nov 12, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #17986

lassebm
lassebm reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lassebm lassebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it needs fixing in line 334 as well.

@arthanson arthanson self-requested a review November 12, 2024 18:28
arthanson
arthanson requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah as mentioned by @lassebm it needs the same change on line 334

@jeremystretch jeremystretch merged commit 9c532c7 into develop Nov 12, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17986-vm-disk-bulk-edit branch November 12, 2024 19:54
jsenecal pushed a commit to jsenecal/netbox that referenced this pull request Nov 12, 2024
@jeremystretch @jsenecal
Fixes netbox-community#17986: Correct label for disk size when bulk e…
48b1c7b 
…diting virtual machines (netbox-community#17992)

* Fixes netbox-community#17986: Correct label for disk size when bulk editing virtual machines

* Correct label for VirtualDisk.size
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lassebm lassebm lassebm left review comments

@arthanson arthanson arthanson requested changes

@bctiemann bctiemann bctiemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect disk size unit when bulk editing VMs
4 participants
@jeremystretch @arthanson @lassebm @bctiemann