Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17740 - Add webp to the list of acceptable extensions for handling filenames in image_upload #17788

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bctiemann
Copy link
Contributor

@bctiemann bctiemann commented Oct 16, 2024

Fixes: #17740

This ensures that image files with a .webp extension will be handled the same way as png, jpg, jpeg, etc. in that the appropriate extension will be appended to the saved file in media.

This addresses a knock-on issue raised in #17740 that a filename with multiple dots will have the rightmost dotted segment treated as the "extension", resulting in a (seemingly) unopenable file after download from NetBox.

@bctiemann bctiemann self-assigned this Oct 16, 2024
@jeremystretch jeremystretch merged commit 81108e4 into develop Oct 16, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17740-add-webp-to-image_upload-develop branch October 16, 2024 20:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image-attachments upload does not sanitize . (dot) in filename and file suffix missing
2 participants