Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17644 fix login icon size #17730

Merged
merged 3 commits into from
Oct 11, 2024
Merged

17644 fix login icon size #17730

merged 3 commits into from
Oct 11, 2024

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Oct 10, 2024

Fixes: #17644

Unfortunately Tabler sets global height: auto and from https://stackoverflow.com/questions/44010645/remove-height-auto-using-css it doesn't look like it is possible to un-set it in css after the fact (also tried to set it just for the login img in css and it doesn't effect it). So directly setting the height here seems like the most narrow change that doesn't effect images elsewhere.

@arthanson arthanson marked this pull request as ready for review October 10, 2024 17:55
@jeremystretch jeremystretch merged commit fcc4986 into develop Oct 11, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17644-login-icon branch October 11, 2024 20:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO icon is not resized since Netbox 4.1.2
3 participants