17419 fix MPTT issue with migrations for nested module bays #17553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
approved these changes
Sep 20, 2024
arthanson
changed the title
There was a problem hiding this comment.
Are we sure it's safe to import the model directly within a migration? IIRC, in the past we've had to jump through some hoops to avoid it.
|
Oh right, good point, the usual pattern is to do like |
bctiemann
approved these changes
Sep 24, 2024
jeremystretch
approved these changes
Sep 26, 2024
bctiemann
pushed a commit
that referenced
this pull request
Oct 11, 2024
* 17419 rebuild module bay tree on upgrade * 17419 rebuild module bay tree on upgrade * 17419 use get_model
jeremystretch
pushed a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
…ommunity#17553) * 17419 rebuild module bay tree on upgrade * 17419 rebuild module bay tree on upgrade * 17419 use get_model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17419
Note in the migration had to use the actual model and not
apps.get_modelas the manager for rebuild is needed.