17422 update custom field group display tag #17423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Sep 10, 2024
There was a problem hiding this comment.
The custom field group heading should be visually distinct from the form field group. Currently they are both rendered as 16px text. I suggest using one of Bootstrap's heading classes to display the <h3> as if it were an <h4> or <h5>.
Additionally, the <h3> element should have the col-9 & offset-3 classes to match the form group heading.
jeremystretch
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17422
Was set at h6 tag, but the "Custom Fields" header above is h2, so making it h3 as that is correct hierarchical wise and also displays at the correct size.