Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17108 - Update isotime and isodate filters to be timezone-aware #17267

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

bctiemann
Copy link
Contributor

@bctiemann bctiemann commented Aug 26, 2024

Fixes: #17108 - Update isotime and isodate filters to be timezone-aware

Wraps the logic of the isodate and isotime filters in the Django localtime util, with the (potentially widespread) effect that every appearance of a datetime in the UI will now respect the TIME_ZONE setting. This particularly fixes the job scheduling UI as seen below (note also that the "Current time" output also now reflects the timezone for added clarity):

Screenshot 2024-08-26 at 11 14 19 AM Screenshot 2024-08-26 at 11 16 56 AM Screenshot 2024-08-26 at 11 19 52 AM

@bctiemann bctiemann self-assigned this Aug 26, 2024
@bctiemann bctiemann added the type: bug A confirmed report of unexpected behavior in the application label Aug 26, 2024
@jeremystretch jeremystretch merged commit 1d2ea90 into develop Aug 26, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17108-localtime-for-scripts branch August 26, 2024 18:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled Jobs Timezone bug
2 participants