Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #17143: Deprecate the use of dedicated nested API serializers #17164

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Aug 14, 2024

Closes: #17143

  • Relocate all nested serializer classes that are still required (i.e. to avoid circular imports) to a new nested module within api/serializers_/ under each app.
  • Remove all imports of the nested_serializers modules.
  • Raise a DeprecationWarning when importing any of the now-obsolete nested_serializers modules. These will be completely removed in NetBox v4.2 per Remove all obsolete nested REST API serializers #17165.

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Aug 14, 2024
@jeremystretch jeremystretch merged commit e3d681b into feature Aug 15, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17143-deprecate-nested-serializers branch August 15, 2024 12:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants