16946 return empty queryset if filterset is not valid #17015

arthanson · 2024-07-29T14:29:49Z

jeremystretch

Could you please add a test for this fix to GraphQLTestCase?

netbox/netbox/graphql/filter_mixins.py

netbox/netbox/tests/test_graphql.py

arthanson added 2 commits July 29, 2024 21:27

16946 raise error if filterset is not valid

55ff836

16946 cleanup

d8de18b

arthanson changed the title ~~DRAFT: 16946 raise error if filterset is not valid~~ 16946 raise error if filterset is not valid Jul 29, 2024

arthanson marked this pull request as ready for review July 29, 2024 14:58

arthanson requested a review from jeremystretch July 29, 2024 14:58

jeremystretch requested changes Aug 10, 2024

View reviewed changes

arthanson added 3 commits August 12, 2024 21:44

Merge branch 'develop' into 16946-graphql-filter-error

28eba4b

Merge branch 'develop' into 16946-graphql-filter-error

4af490a

16946 change to None qs return and add test

0180a35

arthanson changed the title ~~16946 raise error if filterset is not valid~~ 16946 return empty queryset if filterset is not valid Aug 26, 2024

arthanson requested a review from jeremystretch August 26, 2024 18:30

jeremystretch requested changes Aug 26, 2024

View reviewed changes

netbox/netbox/graphql/filter_mixins.py Outdated Show resolved Hide resolved

netbox/netbox/tests/test_graphql.py Outdated Show resolved Hide resolved

jeremystretch added 2 commits August 27, 2024 10:10

Remove obsolete logic

39ac70b

Clean up test case

ee030f8

jeremystretch merged commit 3fee28c into develop Aug 27, 2024
6 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024

jeremystretch deleted the 16946-graphql-filter-error branch December 3, 2024 14:35

Provide feedback