16423 - Inconsistency Swagger schema vs API (model Interface) #16435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Julio-Oliveira-Encora can you please fix the tests that are failing. |
Added get_serializer_class for InterfaceViewSet.
Fixed. |
|
@Julio-Oliveira-Encora I think this is backwards - I don't think we want to change the serializer. The serializer should be returning the nested object. We want to change the REST schema to correctly reflect that the nested object is being returned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16423
Changed
nestedtofalsefordeviceinInterfaceSerializerin device_components.py.