-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16149 add (optional) obj hyperlink to script list table #16271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not appear to resolve #16149; I see the same output in the script result before and after the change. Additionally, the table configuration button does not work on the script result view.
@jeremystretch I'm not seeing those issues? With the branch I get the configuration button, which you need to do as the object is an optional parameter. If you do add the parameter then you do get a clickable link (second screenshot). Is there a data condition I'm missing that is causing the config screen not to appear on yours? |
@arthanson looks like the table configuration button is left in a broken state when the script first completes. It's functional on successive reloads. The modal content is likely missing on the first load. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table configuration button is broken on completion of script execution. Also, we should probably make object
a default table column.
Made object default, the table configuration button wasn't working as the filter list is only included when the script finishes, so made the button dependent on that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arthanson!
Fixes: #16149