Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #15961: Fix secret toggle button by avoiding duplicate event handler #15963

Merged
merged 1 commit into from
May 6, 2024
Merged

Fixes #15961: Fix secret toggle button by avoiding duplicate event handler #15963

merged 1 commit into from
May 6, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #15961

  • Move the callback for .toggle-secret buttons to a named function
  • Call .removeEventHandler() on the element prior to adding the event handler to avoid duplicate registrations

@jeremystretch jeremystretch requested a review from arthanson May 6, 2024 13:28
@jeremystretch jeremystretch merged commit 60aee6f into develop May 6, 2024
8 checks passed
@jeremystretch jeremystretch deleted the 15961-fix-secret-toggle branch May 6, 2024 14:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IKE policy PSK not showing by clicking button
2 participants
@jeremystretch @arthanson