Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #15948 - Fixes cable fanin/fanout when both are required #15953

Merged
merged 2 commits into from
May 6, 2024

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented May 3, 2024

Fixes: #15948 - Fixes cable display when both fanin and fanout are required in cable trace

  • Adjust conditional to check for both fanin and fanout condition
  • Use my sucky maths to figure out a x_center for the fan-in/fan-out

@DanSheps DanSheps marked this pull request as ready for review May 6, 2024 13:18
@DanSheps DanSheps requested a review from jeremystretch May 6, 2024 13:18
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this has restored the original functionality. Thanks @DanSheps! I think it would be beneficial for us to spend some more time on the cable tracing logic as it could stand to be cleaned up a good deal, but for now this is sufficient.

screenshot

@jeremystretch jeremystretch merged commit 56e0449 into develop May 6, 2024
8 checks passed
@jeremystretch jeremystretch deleted the 15948-fix-split-endpoint-cables branch May 6, 2024 13:48
jeremystretch pushed a commit that referenced this pull request May 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cable Trace not working for split cables with multiple endpoints
2 participants