15794 Make "related objects" dynamic #15876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding relationships between models for the detail view, they are now dynamically generated.
Instead of providing a rarely used hook method, additional related models can now be passed directly to the lookup method.
jeremystretch
requested changes
Jun 3, 2024
ASNs have ManyToMany relationships and therefore can't used automatic resolving. Explicit relations have been restored as before.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15794
Instead of hardcoding relationships between models for the detail view, they are now dynamically generated.
Known limitations
If a related model doesn't have a
listview, rendering of the related objects pane will fail. This limitation was already present before, but related models listed were explicitly chosen to do so. For all views shipped with NetBox I've added a filter if needed (omitparameter). However, external plugins might trigger this unintentionally, when named view is not available, but the relationship has not been setup withrelated_name='+'parameter. Switching toverified_viewin the panel's template should resolve this, but might decrease performance slightly.If a model introduces several relations to another model, they will all be listed with the same model name but different URL query parameters. This is not the case for models included in NetBox. As before, plugin developers can still use an extra panel for this special purpose and extra context about the different types of relationships.