-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 15348 - Quick Access Saved Filters #15862
Feature 15348 - Quick Access Saved Filters #15862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Julio-Oliveira-Encora here are the changes after discussion on this:
|
…earch match to the dropdown.
…earch match to the dropdown.
…earch match to the dropdown.
@arthanson I changed the CSS for quick search, because I did get to change the CSS for Dropdown. Please, check them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Julio-Oliveira-Encora I added a saved filter and then selected it, however it didn't actually filter the table - see screenshots. The first is the filter applied manually, the second is selecting it from the saved filter list, they number of results should match but don't.
@arthanson @jeremystretch |
@Julio-Oliveira-Encora I just re-tested this, it is happening when I don't have HTMX navigation enabled |
@Julio-Oliveira-Encora almost there - can you remove the saved-filters from the filters tab. With both the dropdown and it being in filters tab you can get the UI showing both which isn't great: |
if (isTruthy(divResults)) { | ||
const savedFilterSelect = divResults.getElementsByTagName('select')[0]; | ||
if (savedFilterSelect.selectedOptions.length > 0) { | ||
appliedFilter.hidden = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not rely on Javascript to hide this element; rather it should simply not be rendered in the template.
@arthanson can you help Julio with this please?
@Julio-Oliveira-Encora if you need any help with hiding the column in the table, please let me know. |
@arthanson and @jeremystretch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've omitted saved filters from the "applied filters" list and did some cosmetic cleanup of the selector widget.
Feature: #15348
A dropdown was added to list and apply the saved filters to the current view.