Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15761 filter IKE Proposals on IKE Policy detail view #15766

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #15761

IKEProposals were not getting correctly filtered on the IKEPolicy detail view because the matching filters were missing from the Filterset.

@arthanson arthanson marked this pull request as ready for review April 18, 2024 20:48
@arthanson arthanson requested a review from jeremystretch April 18, 2024 20:48
@jeremystretch jeremystretch changed the title 15761 filter IKEProposals on IKEAPolicy detail view 15761 filter IKE Proposals on IKE Policy detail view Apr 19, 2024
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to include a test when introducing a new filter.

@jeremystretch jeremystretch merged commit 88facba into develop Apr 19, 2024
8 checks passed
@jeremystretch jeremystretch deleted the 15761-ikeapolicy branch April 19, 2024 21:09
JCWasmx86 pushed a commit to JCWasmx86/netbox that referenced this pull request Apr 23, 2024
…y#15766)

* 15761 filter IKEAProposals on IKEAPolicy detail view

* Add test for ike_policy filter

---------

Co-authored-by: Jeremy Stretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display bug - all the IKE proposals are display in the IKE policy even if not selected
2 participants