New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15192 fix config revision if no revisions #15207

Merged

jeremystretch merged 1 commit into develop from 15192-fix-config-revision

Feb 20, 2024

Collaborator

arthanson commented Feb 20, 2024

Fixes: #15192

Fixes two related cases when there are no current config revisions:

If there are no config revisions and you go to http://localhost:8000/core/config/ it will error - that fix is in views.py to return the get_config().defaults.
If you are viewing the now working current config page and choose to edit you will get another error on the edit form for 'NoneType' is not iterable. That is the fix in config.py


          15192 fix config revision if no revisions

arthanson marked this pull request as ready for review

February 20, 2024 18:45

arthanson requested a review from jeremystretch

February 20, 2024 18:45

jeremystretch approved these changes

View reviewed changes

jeremystretch merged commit 9b9afdc into develop

8 checks passed

jeremystretch deleted the 15192-fix-config-revision branch

February 20, 2024 19:28

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet