Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14945: Fix "select all" button for device type components #15027

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #14945

This updates the component_templates.html template to inherit from the standard template for subclasses of generic.ObjectChildrenView.

Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the buttons are correct here - the edit and rename buttons aren't separated and the rename is light-yellow text on white background which isn't great for readability (light background).

Monosnap APC AP7901 | NetBox 2024-02-05 09-38-55

@jeremystretch
Copy link
Member Author

jeremystretch commented Feb 5, 2024

Yep, this is correct; it's the same way action buttons for device components appear. (The styling is being updated as part of the UI refresh in v4.0 anyway. The goal here is just to achieve consistency with similar views.)

@jeremystretch jeremystretch changed the base branch from develop to feature February 5, 2024 18:03
@jeremystretch jeremystretch changed the base branch from feature to develop February 5, 2024 18:04
@jeremystretch jeremystretch merged commit 93edf74 into develop Feb 5, 2024
8 checks passed
@jeremystretch jeremystretch deleted the 14945-fix-select-all branch February 5, 2024 18:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select All check box in device Types Interfaces fails to check all boxes
2 participants