Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #14579: Add user language preference #14580

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Closes #14579: Add user language preference #14580

merged 1 commit into from
Dec 21, 2023

Conversation

jeremystretch
Copy link
Member

Fixes: #14579

  • Declare the list of supported languages in settings.LANGUAGES (these are being added)
  • Introduce a new UserConfig parameter: locale.language
  • Extend UserConfigView to set/clear the language cookie depending on the value of this parameter

DanSheps
DanSheps approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeremystretch jeremystretch merged commit 326b54b into feature Dec 21, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 14579-language-preference branch December 21, 2023 19:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanSheps DanSheps DanSheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @DanSheps