Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12751 - Usability improvements for object selector #14387

Conversation

kkthxbye-code
Copy link
Contributor

@kkthxbye-code kkthxbye-code commented Nov 30, 2023

Fixes: #12751

  • Adds preselected filters
  • Applies the filter on selection instead of requiring the search button to be clicked.

The typescript change was because of a bug that was also present for the Saved Filter field. If a collapsible field is defaulted to be shown, the list will not populate when opening like it is supposed to, but only when the user starts typing.

I was a bit uncertain about the selector_fields name, selector_default or selector_default_fields might be better. Feedback appreciated.

The default fields were taken from the initial PR adding selector fields. I looked at what fields were removed from the forms and added them as pre-selected fields.

* Adds preselected filters
* Applies the filter on selection instead of requiring the search button to be pushed
@ITJamie
Copy link
Contributor

ITJamie commented Dec 5, 2023

im wondering should we make a separate issue to mark this as fixing as #12751 lists several issues with the selector. this pr fixes part 2 of the list of issues.

@jeremystretch
Copy link
Member

@ITJamie this is a great example of why it's so important to ensure each feature request conveys a concise, discrete enhancement and to not bundle multiple initiatives in a single issue. If you don't believe this PR fully resolves the FR, I'd suggest breaking out the remaining items into separate FRs so that this can move forward.

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkthxbye-code!

@jeremystretch jeremystretch merged commit 8d39181 into netbox-community:develop Dec 15, 2023
4 checks passed
@c-mege
Copy link

c-mege commented Dec 16, 2023

@kkthxbye-code : thank you !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip address - interface assignment section - object selector - usability adjustments
4 participants