Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #13936: Add primary_ip4 and primary_ip6 filters to VirtualMachine and VirtualDeviceContext filtersets #14203

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Closes #13936: Add primary_ip4 and primary_ip6 filters to VirtualMachine and VirtualDeviceContext filtersets #14203

merged 2 commits into from
Nov 9, 2023

Conversation

miaow2
Copy link
Contributor

@miaow2 miaow2 commented Nov 7, 2023

Fixes: #13936

  • Add primary_ip4 and primary_ip6 to the VirtualmachineFilterSet and VirtualDeviceContextFilterSet
  • Add tests

jeremystretch
jeremystretch approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miaow2!

@jeremystretch jeremystretch merged commit 6b89da2 into netbox-community:develop Nov 9, 2023
4 checks passed
@miaow2 miaow2 deleted the 13936_primary_ip_filter branch November 9, 2023 15:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filters by primary_ips to VirtualMachine, VirtualDeviceContext models
2 participants
@miaow2 @jeremystretch