Closes #14153: Filter ContentTypes by supported feature #14191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
approved these changes
Nov 16, 2023
| @@ -21,6 +21,24 @@ def public(self): | |||
| q |= Q(app_label=app_label, model__in=models) | |||
| return self.get_queryset().filter(q) | |||
|
|
|||
| def with_feature(self, feature): | |||
There was a problem hiding this comment.
Not a part of this PR, but I think we should have a FR to document the registry as it is getting a bit complicated now, for example for a model-feature what it is for, you need to do the following steps (like in the clean validate the content-type), etc...
There was a problem hiding this comment.
We have a page in the developer docs that explains each store. Happy to flesh this out some. (And your comment reminded me to go add the new tables store introduced under #14173.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14153
with_feature()method to the manager for our ContentType proxy model