Closes #13690: List all objects to be deleted

[ITJamie]

Fixes: #13690

List all objects to be deleted when deleting an item.

Currently, the list includes the original item being deleted. we can change that pretty easily but I would like feedback first as to whether the list should be exhaustive or just the additional items (see #13842 as to why including the original item in the list might make sense)

[abhi1693]

I like the general idea but this will turn out to be a bad ux if the similar objects are listed in the new line because it may go beyond the actual page making a huge scroll. I'd prefer the similar objects be comma separated instead.

[ITJamie]

I like the general idea but this will turn out to be a bad ux if the similar objects are listed in the new line because it may go beyond the actual page making a huge scroll. I'd prefer the similar objects be comma separated instead.

I can absolutely refactor for that. For switches it makes a lot of sense as there can be a lot of ports and make the list long.

The one advantage to that is that it really reinforces just how much impact the current deletion will have by having to scroll to the delete button 😂

[abhi1693]

I just noticed this is to be released in v3.7, so it should go into the feature branch instead.

[ITJamie]

@abhi1693 something more like this?

[ITJamie]

@kkthxbye-code re the upvotes and downvotes. Is there anything specific you would like me to adjust regards the ui view change from the first screenshots to the adjusted screenshots based on @abhi1693 feedback?

[kkthxbye-code]

@kkthxbye-code re the upvotes and downvotes. Is there anything specific you would like me to adjust regards the ui view change from the first screenshots to the adjusted screenshots based on @abhi1693 feedback?

I think your initial version was much more readble than the version abhi suggested. Showing a large number of varying length list items as comma seperated tends to look very messy.

If the page size is an issue (I personally don't think it is), maybe a scrolling container could solve it, or truncating the output with a "show more" button that extends it.

Also the trailing comma should be removed if the second version is chosen.

[ITJamie]

Current version:

• using bootstrap accordian
• titles are now being passed in + using plurals
• added _get_dependent_objects to ObjectDeleteView class
• using

[jeremystretch]

Nice work @ITJamie!