-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #8356: Add virtual disk to Virtual Machines #14087
Conversation
Can i suggest that we add config context to the new VirtualDisk model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @arthanson! Just have some minor cleanup notes.
Also, we should consider how best to report disk space for a VM given the presence of both VirtualDisks and the disk
field on VirtualMachine. E.g. it might make sense to introduce a total_disk_size
property on VirtualMachine.
Just a minor note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to take a stab at annotating the disk size on VM querysets.
Fixes: #8356
introduces a new
VirtualDisk
model withname
andsize
fields, instances of which must be assigned to a specific virtual machine. Retains the existingdisk
field on VirtualMachine.Switched Virtual Machine list view to show Disk Size (from Virtual Disks) instead of Disk - made it default, but user can add disks back if needed. I think this makes it very clear that they should be moved.
Also put in deprecation warnings for Disk in detail / edit view:
Added Virtual Disks to end of Virtual Machine detail view:
