Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces device_role with role on device model #13342

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Replaces device_role with role on device model #13342

merged 6 commits into from
Aug 2, 2023

Conversation

abhi1693
Copy link
Member

@abhi1693 abhi1693 commented Aug 2, 2023

Fixes: #6391

@abhi1693 abhi1693 requested a review from jeremystretch August 2, 2023 08:21
@abhi1693 abhi1693 added the beta Concerns a bug/feature in a beta release label Aug 2, 2023
jeremystretch
jeremystretch requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for plowing through all of this!

netbox/dcim/api/serializers.py Show resolved Hide resolved
netbox/dcim/filtersets.py Show resolved Hide resolved
netbox/dcim/models/devices.py Outdated Show resolved Hide resolved
netbox/dcim/tables/devices.py Show resolved Hide resolved
netbox/netbox/settings.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 0bb86f1 into feature Aug 2, 2023
@jeremystretch jeremystretch deleted the feat/6391-role branch August 2, 2023 13:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch requested changes

Assignees
No one assigned
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi1693 @jeremystretch