Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sensitive_parameters to DataBackend #13203

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

abhi1693
Copy link
Member

Fixes: #12625

I have added a new parameter sensitive_parameters which takes a list of fields that should be considered to contain confidential information like keys and passwords.

@jeremystretch I'm not sure if I should keep the perms check in the template, kindly advise.

@abhi1693 abhi1693 requested a review from jeremystretch July 18, 2023 10:05
@jeremystretch
Copy link
Member

I'm not sure if I should keep the perms check in the template, kindly advise.

Makes sense to me. Thanks for taking this!

@jeremystretch jeremystretch merged commit 0276f29 into develop Jul 27, 2023
@jeremystretch jeremystretch deleted the feat/12625-ds-password branch July 27, 2023 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource passwords are displayed in plaintext
2 participants