Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oob ip (devices) #13013

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Oob ip (devices) #13013

merged 11 commits into from
Jul 25, 2023

Conversation

ITJamie
Copy link
Contributor

@ITJamie ITJamie commented Jun 26, 2023

Fixes: #8137

a first stab at oob_ip for devices. If we are happy to go this route I will add more commits for virtualmachines (also do we want to add oob_ip to the virtualdevicecontext models (it has primary_ip already)?

@ITJamie
Copy link
Contributor Author

ITJamie commented Jun 26, 2023

(please ignore test failures for now, just a POC to confirm the method)

@jeremystretch would you be happy with this approach for oob_ip?
there was previously talk in #11953 (comment) about considering another way.

If you are happy with the method in this PR for devices, I will flesh it out more for vms

edit device view:
Screenshot 2023-06-26 at 22 40 27
IP address view (note checkboxes to show if primary IP or oob IP)
Screenshot 2023-06-26 at 22 40 04
Device view:
Screenshot 2023-06-26 at 22 39 47
)

@ITJamie ITJamie marked this pull request as ready for review June 29, 2023 18:07
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Jul 6, 2023
@jeremystretch
Copy link
Member

@ITJamie thanks for taking this on. Per my comment here, my intent was to introduce only a single oob_ip field to the Device model.

@jeremystretch
Copy link
Member

Also, could you rebase this on the feature branch please?

@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 24, 2023

just to check @jeremystretch are you ok with this overall method or do you want me to redo this with the m2m relationship? i had started a POC of the m2m relationship (#13094) but have been pulled onto another project

@jeremystretch
Copy link
Member

@ITJamie We won't have the time or bandwidth to explore a change to the underlying relationship for multiple fields as part of the v3.6 release, so if we're going to ship this as part of the beta we'll need to stick with replicating the existing pattern (the direct foreign key relationship). Thanks!

@ITJamie ITJamie changed the base branch from develop to feature July 24, 2023 20:07
@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 24, 2023

ok ill rework it now to have only a single oob_ip

@ITJamie
Copy link
Contributor Author

ITJamie commented Jul 24, 2023

refactored down to a single field

@jeremystretch
Copy link
Member

Thanks @ITJamie!

@jeremystretch jeremystretch merged commit 154b823 into netbox-community:feature Jul 25, 2023
@bitcollector1
Copy link

Thanks again for the extra work, it's much appreciated!

Hard to believe how much NetBox has matured since I originally requested this. This team is pretty awesome!!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new field to Device/VM models for out-of-band management IP address
3 participants