-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oob ip (devices) #13013
Oob ip (devices) #13013
Conversation
(please ignore test failures for now, just a POC to confirm the method) @jeremystretch would you be happy with this approach for oob_ip? If you are happy with the method in this PR for devices, I will flesh it out more for vms edit device view: |
Also, could you rebase this on the |
just to check @jeremystretch are you ok with this overall method or do you want me to redo this with the m2m relationship? i had started a POC of the m2m relationship (#13094) but have been pulled onto another project |
@ITJamie We won't have the time or bandwidth to explore a change to the underlying relationship for multiple fields as part of the v3.6 release, so if we're going to ship this as part of the beta we'll need to stick with replicating the existing pattern (the direct foreign key relationship). Thanks! |
ok ill rework it now to have only a single oob_ip |
refactored down to a single field |
Thanks @ITJamie! |
Thanks again for the extra work, it's much appreciated! Hard to believe how much NetBox has matured since I originally requested this. This team is pretty awesome!! |
Fixes: #8137
a first stab at oob_ip for devices. If we are happy to go this route I will add more commits for virtualmachines (also do we want to add oob_ip to the virtualdevicecontext models (it has primary_ip already)?