12625 hide datasource password #12743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +89,18 @@ <h5 class="card-header">Backend</h5> | |||
| {% for name, field in object.get_backend.parameters.items %} | |||
| <tr> | |||
| <th scope="row">{{ field.label }}</th> | |||
| <td>{{ object.parameters|get_key:name|placeholder }}</td> | |||
| {% if field.label == "Password" and object.parameters|get_key:name %} | |||
There was a problem hiding this comment.
I don't think this is going to be a viable approach. We can't rely on the field label to infer whether the parameter should be displayed. (And even if we could, hard-coding this in the template should be considered poor practice.) We should devise some approach to explicitly set some attribute on the parameter itself to control its display.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12625
Change datasource.html to hide password until the "show secret" button is clicked. I have the permissions to view set for update/change/add instead of view. As if a user doesn't have view for core/datasource, they wouldn't be able to see the page anyways. Unless I'm misunderstanding something.