Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12416 warning for missing script file #12456

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

arthanson
Copy link
Collaborator

Fixes: #12416

Fixes the case of missing script files causing the script list view to error out. Now shows a warning message for the admin to check the file (see screenshot below). Also removed a left-over print statement in the code.

Monosnap Scripts | NetBox 2023-05-03 14-26-20

@arthanson arthanson requested a review from jeremystretch May 3, 2023 21:38
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some tweaks, let me know what you think.

netbox/extras/models/scripts.py Outdated Show resolved Hide resolved
netbox/templates/extras/script_list.html Outdated Show resolved Hide resolved
@arthanson arthanson requested a review from jeremystretch May 4, 2023 19:01
@jeremystretch
Copy link
Member

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 9909213 into develop May 5, 2023
@jeremystretch jeremystretch deleted the 12416-custom-script branch May 5, 2023 13:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add or remove scripts from Custom Scripts after updating to 3.5.0
2 participants