Fixes #12402 - When bulk-importing related objects, add the errors to the base form instead of the model_form #12408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12402
The errors of related models are currently added to the
model_form
. If there's any errors in a related object form, an AbortTransaction is thrown. The errors saved on the model form are never replicated to the base form and thus are never shown on the form.I'm really unsure of the fix in this PR, but it seems to work. The code is pretty complex imo, a lot of different forms being passed around, so not sure if there's a better way. Feel free to just close this PR and fix it another way, just wanted to have it written down.