Feature/remote group autocreate #12394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the database. Closes netbox-community#7671
Apply the fix requested by kkthxbye-code in netbox-community#8603
|
@kkthxbye-code Any suggestions on this PR? I mention you as you commented on the previous one for this feature. |
|
LGTM. The only thing missing is a documentation entry for the new config parameter. Happy to add that myself. Thanks @jschewebbn! |
jsenecal
pushed a commit
to jsenecal/netbox
that referenced
this pull request
May 18, 2023
* Add REMOTE_AUTH_AUTOCREATE_GROUPS When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the database. Closes netbox-community#7671 * Fix naming of parameter Apply the fix requested by kkthxbye-code in netbox-community#8603 --------- Co-authored-by: Lars Kellogg-Stedman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7671
When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups
referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the
database.
This is a rebase of #8603 onto the current develop with the fix noted by @kkthxbye-code.
I note that REMOTE_AUTH_AUTO_CREATE_GROUPS is plural while REMOTE_AUTH_AUTO_CREATE_USER is singular. Would the maintainers like the group parameter to be singular as well?