Fixes color mode selection

[abhi1693]

Fixes: #12330

[jeremystretch]

Thanks @abhi1693! I'm going to hold off on this until v3.5, just because it touches a lot of Javascript that may be difficult to fully test across various browsers & operating systems, and v3.4.9 is the last planned release for v3.4

[abhi1693]

This is supposed to be released under v3.5 only due to the reasons you have mentioned and the introduction of a new option.

[jeremystretch]

I haven't dug into this, but it appears to break the ability to toggle light/dark mode using the link under the user menu (top right corner).

[abhi1693]

Ok, so the functionality only works when changed via the Profile option. Via that it still works as expected. Do we need the extra options in the footer and the top-right drop-down? Because the whole idea was to get rid of local storage to avoid further issues.

I played around with the code a bit more and it requires more work if we want to keep the extra buttons for convenience. I overlooked the rack-elevation fix in my previous commit though.

[jeremystretch]

Do we need the extra options in the footer and the top-right drop-down?

Yes, I believe we want to keep those, so that users have the option of easily toggling light/dark mode directly within the UI.

[abhi1693]

I'll redo the implementation using local storage only and I think I should be able to clean up the complex logic that's in there.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

[github-actions]

This PR has been automatically closed due to lack of activity.