Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11955 remove csvdatafield csvfilefield #11966

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

arthanson
Copy link
Collaborator

Fixes: #11955

Removes unused CSVDataField, CSVFileField

@arthanson arthanson marked this pull request as ready for review March 13, 2023 15:38
@arthanson arthanson requested a review from jeremystretch March 13, 2023 15:38
@jeremystretch
Copy link
Member

Although these classes are no longer used, we should defer their removal to a minor release (i.e. v3.5) just in case someone is making use of them "unofficially." Could you rebase this PR to the feature branch?

@jeremystretch jeremystretch changed the base branch from develop to feature March 16, 2023 12:35
@jeremystretch jeremystretch force-pushed the 11955-remove-csvdatafield branch from 6b6f85c to ca39ce5 Compare March 16, 2023 18:37
@jeremystretch jeremystretch merged commit 5b81986 into feature Mar 16, 2023
@jeremystretch jeremystretch deleted the 11955-remove-csvdatafield branch March 16, 2023 19:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVDataField and CSVFileField are unused and should be removed
2 participants