11539 empty lookup handle non boolean params #11556
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11539
The issue requested that a 404 be returned, but IMHO this is not consistent with how other filter params work, if you filter on "region_id=ss" it won't 404 but just return no values from the query. This change uses strtobool "True values are y, yes, t, true, on and 1; false values are n, no, f, false, off and 0" for anything else it interprets it as false. Also cleaned up the return string to make it a bit easier to read what exactly is going on. Unfortunately strtobool raises a ValueError if the string doesn't match a valid input, so needed to wrap that.