Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added device and vm tab on device role #11500

Merged
merged 4 commits into from
Jan 20, 2023
Merged

added device and vm tab on device role #11500

merged 4 commits into from
Jan 20, 2023

Conversation

abhi1693
Copy link
Member

Fixes: #11228

@jeremystretch
Copy link
Member

IMO if we're going to have a tab for VMs, we should move the devices table to a tab as well, to keep things orderly. However, I also just recently opened #11517, which asserts that the device role view should not list _either_type, for feedback. If accepted, it would render this issue moot.

@abhi1693
Copy link
Member Author

I'll still go ahead and make the required changes in case it's needed to be merged.

@abhi1693 abhi1693 changed the title added vm tab on device role added device and vm tab on device role Jan 18, 2023
@jeremystretch
Copy link
Member

Thanks @abhi1693!

@jeremystretch jeremystretch merged commit ddd4f80 into netbox-community:develop Jan 20, 2023
@abhi1693 abhi1693 deleted the fix/11228-device-role-vm-tab branch January 20, 2023 14:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Roles: Add Virtual Maschines view
2 participants
@abhi1693 @jeremystretch