-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8927 plugin search #10489
Merged
Merged
8927 plugin search #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
force-pushed
the
8927-plugin-search
branch
from
October 10, 2022 12:59
d2db498
to
777e883
Compare
This has gone through a few iterations, building on @arthanson's initial work, but ultimately I ended up settling on the following for this FR (with additional work remaining to be done under #10560):
We'll undoubtedly need to keep adjusting the search backends implementation under #10560, but this feels like a solid start, and meets the primary objective of enabling global search for plugin models. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8927
Refactors and adds to the search code to allow two things:
The major changes are moving the search definitions to be class based (from the current dictionary), adding in a pluggable search backend system and making the search registration auto-scan the apps (which requires the class based definitions) to dynamically pick up new apps and plugins.