Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #9249: Ignore case for device/VM names #10488

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Closes #9249: Ignore case for device/VM names #10488

merged 3 commits into from
Sep 28, 2022

Conversation

jeremystretch
Copy link
Member

Closes: #9249

  • Adjust the uniqueness constraints on the Device and VirtualMachine models to use the Lower('name') expression rather than the raw name value.
  • Adjust the name filters for Device and Virtual Machine to use the case-insensitive iexact lookup.
  • Add relevant model and filter tests.

@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Sep 27, 2022
arthanson
arthanson approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue - just be people should be aware, if you do have existing duplicates and edit the record it will show the error so you will have to update the name, might surprise someone as it was already existing.

@jeremystretch jeremystretch merged commit 5382ac2 into feature Sep 28, 2022
@jeremystretch jeremystretch deleted the 9249-device-vm-names branch September 28, 2022 21:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @arthanson