-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10348 add decimal custom field #10422
Conversation
5a389cd
to
818bbf0
Compare
818bbf0
to
91ec210
Compare
…ity/netbox into 10348-decimal-custom-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The only issue I see at the moment is that decimal values are being stored as strings, rather than decimals/floats. Need to dig into this some more.
Ok, tracked this down. The Ideally, we should save these as raw JSON numbers. I'm not sure of the impact on precision, however it's probably acceptable. If storing decimal values as JSON numbers is not tenable, an alternative would be to store them as strings but convert to decimals under |
This should be about ready to go. We still need to resolve the validation issue with MultiValueDecimalFilter that @arthanson called out in ad6d4f8, but that should be addressed separately as it may have implications for other filters. |
Fixes: #10348
Adds custom decimal field type and associated tests.