Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSO signon for SAML with idp #10137

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Fix SSO signon for SAML with idp #10137

merged 5 commits into from
Aug 25, 2022

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Aug 24, 2022 •
edited
Loading

Fixes: #10135

SAML signin usually requires passing an idp in the query param, this updates so if doing SAML sign-in and have SOCIAL_AUTH_SAML_ENABLED_IDPS defined it will add those to the sing-in (see screenshot). Also refactors the auth_backends context to be more extensible.

saml

@jeremystretch jeremystretch merged commit a9ddd41 into netbox-community:develop Aug 25, 2022
arthanson added a commit that referenced this pull request Sep 20, 2022
@arthanson
Fix SSO signon for SAML with idp (#10137)
50bd7b9 
* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 add idp to saml login

* #10135 refactor / cleanup
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSO doesn't work for SAML accounts that require idp
2 participants
@arthanson @jeremystretch