Fix #10094 - Contact Assignments Create and Add Another #10103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Aug 23, 2022
There was a problem hiding this comment.
I like the approach of adding a get_extra_addanother_params() method to the view, but we want to keep it as simple as possible because it will need to be added to the plugins API for the view.
jeremystretch
requested changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10094
Fixes for Contact Assignment create and Add Another (previously returning a 404 error:
Steps to Reproduce
Click 'Add a Contact' on a Device or Virtual Machine (possibly others) detail page.
Enter Contact and Role.
Click 'Create & Add Another'
adds a get_extra_addanother_params() to ObjectEditView that can be overridden to set extra query params for the button.