Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6454 - Adds warning for prerequisite models #10096

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Aug 22, 2022

Fixes: #6454

Adds warnings to list and detail view screens if pre-requisite models have not been created. Fox example, if you try to create a device without having any site objects it will warn you that you first need to create at least one site and provides the Add button to go there (see screenshot):

screencap-aug-22

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some minor suggestions for cleanup but looks great! Thanks!

netbox/netbox/views/generic/bulk_views.py Outdated Show resolved Hide resolved
netbox/netbox/views/generic/bulk_views.py Outdated Show resolved Hide resolved
netbox/netbox/views/generic/object_views.py Outdated Show resolved Hide resolved
netbox/netbox/views/generic/object_views.py Outdated Show resolved Hide resolved
netbox/templates/generic/object_list.html Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit f35ff10 into netbox-community:develop Aug 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include contextual help in UI for new installations
2 participants