Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack (inner) depth #9832

Closed
sieuwe opened this issue Jul 25, 2022 · 7 comments
Closed

Rack (inner) depth #9832

sieuwe opened this issue Jul 25, 2022 · 7 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@sieuwe
Copy link

sieuwe commented Jul 25, 2022

NetBox version

v3.2.7

Feature type

Data model extension

Proposed functionality

Currently we have a width and height option for inner sizing of a rack.
And the outer width and outer depth is also available.
What we are missing is the possibility to add the inner depth.

Use case

There are different inner depths possible.
Some hardware only fits from a certain depth.

Database changes

Depth field needs to be added

External dependencies

No response

@sieuwe sieuwe added the type: feature Introduction of new functionality to the application label Jul 25, 2022
@jeremystretch
Copy link
Member

This is a good idea, but your FR needs much more detail.

  • What field(s) are you proposing be added to the rack model?
  • Do we want to allow specifying the measurement unit as we do for the outer depth?
  • Should the use of this field be limited by rack type?

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Jul 25, 2022
@sieuwe
Copy link
Author

sieuwe commented Jul 25, 2022

  • What field(s) are you proposing be added to the rack model?
    I'd suggest using 'inner depth' since that would clarify the use and make it not confusing when using depth and outer depth.
  • Do we want to allow specifying the measurement unit as we do for the outer depth?
    The same measurement unit could apply as for the outer depth.
  • Should the use of this field be limited by rack type?
    This applies to al rack types.

@jeremystretch
Copy link
Member

This applies to al rack types.

What about a freestanding two-post frame?

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: revisions needed This issue requires additional information to be actionable labels Jul 26, 2022
@sieuwe
Copy link
Author

sieuwe commented Jul 27, 2022

What about a freestanding two-post frame?

Overlooked that one. That shouldn't have an inner dimension, all the other types should have one.

@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Jul 27, 2022
@jeremystretch jeremystretch added this to the v3.4 milestone Jul 27, 2022
@gellis713
Copy link
Contributor

gellis713 commented Aug 11, 2022

This applies to al rack types.

What about a freestanding two-post frame?

I've worked in many broom closets that have limited space behind the two-post frame (a wall). Inner depth could be relevant still and may simplify the model. (I don't suppose it's truly any different than an outer depth in this case but some people may want to standardize checking against equipment depth on one field.)

I've made the necessary additions needed to submit a pull request assuming it is OK to have a dedicated "inner_unit" field. Otherwise we'll need to potentially complicate UI design and checks on whether fields are defined (which is fine will just need more careful planning)

@AnythingOverIP
Copy link

Inner depth as in rail-to-rail distance or door-to-door? I would personally like to have rail-to-rail tracked, and maybe even have a min/max rail depth added to the device types. We currently document that through custom properties, but did not script any validation yet...

Some manufacturers have that information documented ( https://i.dell.com/sites/csdocuments/Business_solutions_engineering-Docs_Documents/en/rail-rack-matrix.pdf ) and we rely on that as we have hundreds of sites across the country with no unique rack model...

Having all that information added would be a plus, and that would also help to revisit #1627 ?

@jeremystretch
Copy link
Member

Inner depth as in rail-to-rail distance or door-to-door?

Rail-to-rail

Having all that information added would be a plus, and that would also help to revisit #1627?

Possibly, but it would be best to submit a new FR after this one has been implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants