Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option for LDAP server certificate validation #9722

Closed
tobiasge opened this issue Jul 14, 2022 · 4 comments · Fixed by #10567
Closed

Configuration option for LDAP server certificate validation #9722

tobiasge opened this issue Jul 14, 2022 · 4 comments · Fixed by #10567
Assignees
@tobiasge
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@tobiasge
Copy link
Member

tobiasge commented Jul 14, 2022 •
edited
Loading

NetBox version

v3.2.6

Feature type

Change to existing functionality

Proposed functionality

Add setting LDAP_CA_CERT_FILE and LDAP_CA_CERT_DIR to specify a CA certificate for LDAP server certificate validation.

Use case

Active directory servers often use certificates that are signed by an AD integrated CA. Currently there is no easy way to set this CA certificate in Netbox.

Database changes

  • None

External dependencies

  • None
@tobiasge tobiasge added the type: feature Introduction of new functionality to the application label Jul 14, 2022
@tobiasge
Copy link
Member Author

I have prepared the needed changes here. Should this (if accepted) go into develop or feature?

@tobiasge tobiasge mentioned this issue Jul 14, 2022
Closed
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 13, 2022
@tobiasge
Copy link
Member Author

@jeremystretch Is this a feature you would consider merging or should this issue be closed?

@jeremystretch
Copy link
Member

@tobiasge, sorry this one slipped by. Please go ahead with a PR. I'd like to get some other people to help test.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed pending closure Requires immediate attention to avoid being closed for inactivity labels Oct 5, 2022
@tobiasge tobiasge mentioned this issue Oct 5, 2022
Merged
jeremystretch added a commit that referenced this issue Oct 5, 2022
@jeremystretch
Changelog for #9669, #9722
a9e583a
@jeremystretch jeremystretch mentioned this issue Oct 26, 2022
Merged
@szeestraten szeestraten mentioned this issue Oct 27, 2022
Closed
@anubisg1 anubisg1 mentioned this issue Oct 31, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobiasge tobiasge

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added LDAP_CA_CERT_* to LDAP settings
2 participants
@tobiasge @jeremystretch