Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Location to Circuit Termination #9604

Closed
gjvc opened this issue Jun 24, 2022 · 7 comments
Closed

Add Location to Circuit Termination #9604

gjvc opened this issue Jun 24, 2022 · 7 comments
Assignees
Labels
breaking change This change modifies or removes some previously documented functionality complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@gjvc
Copy link

gjvc commented Jun 24, 2022

NetBox version

v3.2.5

Feature type

Data model extension

Proposed functionality

When editing a circuit termination, i can specify "Region", "Site group", and "Site", but not "Location".

I would like to specify the "Location" field (optionally) as part of the termination.

Use case

We have cross-connects between our cage and cages of other tenants in Equinix. Each tenant's cage is identified by placing the Equinix cage ID in the "Location" field, and this works well in the "Region / Site Group / Site / Location" containment hierarchy.

Right now I am having to specify the tenant's cage as the "Site", because "Location" is not available to me when editing the circuit termination, which makes for something of an impedance mismatch.

Database changes

add foreign key from CircuitTerminations to Location, (where null=True)

External dependencies

None

@gjvc gjvc added the type: feature Introduction of new functionality to the application label Jun 24, 2022
@gjvc
Copy link
Author

gjvc commented Jun 25, 2022

basic diff (no migration or PR yet etc) here develop...gjvc:9604-add-location-to-circuittermination for clarity / discussion.

  • added location field to ProviderForm
  • added location foreign key to CircuitTermination
  • added location field to circuittermination_edit.html template
  • updated circuits table to display Side A/B value via this logic:
    - if location is set, show location
    - if site only is set, show site (as before)
    - if provider_network only is set, show provider_network (as before)

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jul 7, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 12, 2022
@eronlloyd
Copy link

As a service provider trying to get better PoP records for interconnects, etc., I think this could help. @gjvc do you think you can complete your code as a PR in the near future?

@gjvc
Copy link
Author

gjvc commented Sep 14, 2022

@eronlloyd Certainly can! I will make a diff against develop this week and create a PR. Thank you for your consideration. :-)

@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Sep 15, 2022
@gjvc
Copy link
Author

gjvc commented Dec 1, 2022

@jeremystretch would you be able to provide a milestone for this?

@GoldyXXD
Copy link

This would be very handy for us as well. For us Sites is more of a 'compound' large area. Whereas Locations is down to the building within that area. And multiple circuits could come into different buildings.

@jeremystretch jeremystretch added the status: backlog Awaiting selection for work label May 21, 2024
@arthanson arthanson added the complexity: low Requires minimal effort to implement label May 22, 2024
@jeffgdotorg jeffgdotorg added this to the v4.1 milestone May 31, 2024
@jeffgdotorg jeffgdotorg removed the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Jun 7, 2024
@arthanson arthanson assigned arthanson and unassigned arthanson Jul 9, 2024
@jeremystretch jeremystretch removed this from the v4.1 milestone Jul 12, 2024
@jeffgdotorg jeffgdotorg added the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Jul 14, 2024
@jeffgdotorg jeffgdotorg changed the title add Location to circuit termination Add Location to Circuit Termination Jul 14, 2024
@lorsung
Copy link

lorsung commented Jul 18, 2024

I agree with @GoldyXXD, we have sites with multiple demarcs and this would be really helpful.

@jeremystretch jeremystretch added this to the v4.2 milestone Sep 26, 2024
@jeremystretch jeremystretch removed the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Sep 26, 2024
@arthanson arthanson self-assigned this Oct 3, 2024
@arthanson arthanson added the status: accepted This issue has been accepted for implementation label Oct 3, 2024
@jeremystretch jeremystretch added v4.2 and removed v4.2 labels Oct 18, 2024
@jeremystretch jeremystretch removed the status: backlog Awaiting selection for work label Oct 25, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch jeremystretch added the breaking change This change modifies or removes some previously documented functionality label Nov 22, 2024
jeremystretch added a commit that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change modifies or removes some previously documented functionality complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants