Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CSRF_COOKIE_NAME in configuration.py #9277

Closed
tyler-8 opened this issue May 2, 2022 · 3 comments · Fixed by #9415
Closed

Expose CSRF_COOKIE_NAME in configuration.py #9277

tyler-8 opened this issue May 2, 2022 · 3 comments · Fixed by #9415
Assignees
@tyler-8
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@tyler-8
Copy link
Contributor

tyler-8 commented May 2, 2022 •
edited
Loading

NetBox version

v3.2.2

Feature type

New functionality

Proposed functionality

Similar to #6197, allow admins to set an optional CSRF_COOKIE_NAME settings in their configuration.py.

Use case

The default csrftoken is generic and could overlap with other applications/services running in the same domain as NetBox. Allowing admins to change this would help prevent conflicts in environments that need a unique name.

Database changes

None

External dependencies

None
@tyler-8 tyler-8 added the type: feature Introduction of new functionality to the application label May 2, 2022
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 3, 2022
@tyler-8
Copy link
Contributor Author

tyler-8 commented May 3, 2022

@jeremystretch I'll take this

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 3, 2022
@jeremystretch
Copy link
Member

@tyler-8 are you still working on this?

@tyler-8 tyler-8 mentioned this issue May 24, 2022
Merged
@tyler-8
Copy link
Contributor Author

tyler-8 commented May 24, 2022

@tyler-8 are you still working on this?

PR submitted, I changed laptops since opening the issue and still catching up :D

jeremystretch added a commit that referenced this issue May 24, 2022
@jeremystretch
Changelog for #9277
2e5a5f7
@jeremystretch jeremystretch mentioned this issue May 31, 2022
Merged
@tyler-8 tyler-8 mentioned this issue Aug 9, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tyler-8 tyler-8

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional CSRF_COOKIE_NAME setting, update example config, and docs. tyler-8/netbox
2 participants
@jeremystretch @tyler-8