Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set alters_data=True on model methods as appropriate #9077

Closed
jeremystretch opened this issue Apr 7, 2022 · 0 comments
Closed

Set alters_data=True on model methods as appropriate #9077

jeremystretch opened this issue Apr 7, 2022 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Audit the code base and set alters_data=True on all model methods which alter object data.

Justification

The Django documentation recommends this to avoid accidentally calling potentially destructive methods when rendering templates.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Apr 7, 2022
@jeremystretch jeremystretch added this to the v3.6 milestone May 16, 2023
@arthanson arthanson self-assigned this May 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

2 participants