Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Network Service ID #7681

Closed
ryanmerolle opened this issue Oct 29, 2021 · 4 comments
Closed

Provider Network Service ID #7681

ryanmerolle opened this issue Oct 29, 2021 · 4 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@ryanmerolle
Copy link
Contributor

NetBox version

v3.0.8

Feature type

Data model extension

Proposed functionality

Most Service Providers assign a Service ID to the provider networks. It would be ideal if that were extended in the model.

The alternative is to just set a custom field for this, but I figure it is a common enough use case that the data model extension could be seen as reasonable.

Use case

For those who setup multiple mesh / provider networks, or need to call out a provider network issue, it is ideal to be able to track the service id of such a network.

Database changes

No response

External dependencies

No response

@ryanmerolle ryanmerolle added the type: feature Introduction of new functionality to the application label Oct 29, 2021
@YWatchman
Copy link

I created a customfield 'line_tag' which can optionally do regex validation, I think this is better to create as a customfield. Circuit IDs and cables should be documented under the section which is made for it.

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Nov 5, 2021
@jeremystretch jeremystretch added this to the v3.2 milestone Nov 11, 2021
@ryanmerolle
Copy link
Contributor Author

ryanmerolle commented Nov 12, 2021

I created a customfield 'line_tag' which can optionally do regex validation, I think this is better to create as a customfield. Circuit IDs and cables should be documented under the section which is made for it.

I'm not sure I understand why it's better as a customfield. That is a good option, I just propose updating the model since many VPLS providers allow you to provision multiple provider networks if you so choose. They identify said networks with service ids in addition to the normal handoff circuit ids.

@DanSheps
Copy link
Member

DanSheps commented Nov 15, 2021

I agree with Ryan, in a round about way.

Our provider has a circuit id and a "BPSO" (Big pipe service order) and I am sure many other providers are similar, so I think having an additional field is good approach.

@jeremystretch
Copy link
Member

I created a customfield 'line_tag' which can optionally do regex validation, I think this is better to create as a customfield

FYI custom validation was added for all fields in NetBox v3.0.

@jeremystretch jeremystretch self-assigned this Dec 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants