Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static content error on air gapped NetBox #6966

Closed
rodvand opened this issue Aug 16, 2021 · 6 comments
Closed

Static content error on air gapped NetBox #6966

rodvand opened this issue Aug 16, 2021 · 6 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@rodvand
Copy link
Contributor

rodvand commented Aug 16, 2021

NetBox version

v3.0-beta2

Python version

3.8

Steps to Reproduce

  1. Have an air gapped NetBox
  2. Install Netbox v3.0-beta2
  3. Visit NetBox front page

Expected Behavior

Front page to load.

Observed Behavior

Static Media Failure
The following static media file failed to load: netbox-external.css

The netbox-external.css seems to try loading https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700;800&display=swap in netbox-external.css. Removing this reference make the page load again without error.

@rodvand rodvand added the type: bug A confirmed report of unexpected behavior in the application label Aug 16, 2021
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Aug 16, 2021
@jeremystretch
Copy link
Member

From what I've read, the process to embed a Google font locally seems fairly involved. If this is going to mean jumping through hoops, I'd much rather ditch the custom font for something stock. What's your take, @thatmattlove?

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Aug 16, 2021
@bellwood
Copy link
Contributor

It's not overly complicated and once it's done, you're done, unless you want to load more fonts later on:

https://www.wpmediamastery.com/host-google-fonts-locally/

That being said, I'm all for stock fonts.

@thatmattlove
Copy link
Contributor

The best way to self-hosting nowadays is to use something like fontsource and just manage it like any other external dependency. I've just tested this locally and it seems to work perfectly with essentially no hoops.

That said, I don't care about fonts either way. The use of Inter came from our internal discussions about lifting design choices from Volt, and that sort of came along with it. I'm open to suggestions about how to move forward.

@thatmattlove
Copy link
Contributor

@rodvand @bellwood @jeremystretch Anybody got any opinions on how to proceed with this?

@bellwood
Copy link
Contributor

I'm all in favor of ditching external dependancies where possible.

In a utility app, typography doesn't need to be fancy.

@jeremystretch
Copy link
Member

Agreed; let's just ditch the external font for v3.0. Happy to revisit in the future.

@thatmattlove thatmattlove self-assigned this Aug 20, 2021
@thatmattlove thatmattlove added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

4 participants