-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static content error on air gapped NetBox #6966
Comments
From what I've read, the process to embed a Google font locally seems fairly involved. If this is going to mean jumping through hoops, I'd much rather ditch the custom font for something stock. What's your take, @thatmattlove? |
It's not overly complicated and once it's done, you're done, unless you want to load more fonts later on: https://www.wpmediamastery.com/host-google-fonts-locally/ That being said, I'm all for stock fonts. |
The best way to self-hosting nowadays is to use something like fontsource and just manage it like any other external dependency. I've just tested this locally and it seems to work perfectly with essentially no hoops. That said, I don't care about fonts either way. The use of Inter came from our internal discussions about lifting design choices from Volt, and that sort of came along with it. I'm open to suggestions about how to move forward. |
@rodvand @bellwood @jeremystretch Anybody got any opinions on how to proceed with this? |
I'm all in favor of ditching external dependancies where possible. In a utility app, typography doesn't need to be fancy. |
Agreed; let's just ditch the external font for v3.0. Happy to revisit in the future. |
NetBox version
v3.0-beta2
Python version
3.8
Steps to Reproduce
Expected Behavior
Front page to load.
Observed Behavior
The netbox-external.css seems to try loading
https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700;800&display=swap
innetbox-external.css
. Removing this reference make the page load again without error.The text was updated successfully, but these errors were encountered: